Skip to content

[webgui] fix 404 link and typos - #23780

Merged
linev merged 5 commits into
root-project:masterfrom
ferdymercury:patch-23
Oct 21, 2026
Merged

linev merged 5 commits into
root-project:masterfrom
ferdymercury:patch-23

Conversation

@ferdymercury

Copy link
Copy Markdown
Collaborator

reported in the forum

@ferdymercury ferdymercury added the skip code analysis Skip the code analysis CI steps for this PR, including verifying clang-formatting and running Ruff. label Oct 21, 2026
Comment thread gui/webdisplay/src/RWebWindowsManager.cxx Outdated
Comment thread gui/gui/src/TRootGuiFactory.cxx Outdated
Comment thread gui/webdisplay/src/RWebWindowsManager.cxx Outdated
Comment thread gui/gui/src/TRootGuiFactory.cxx Outdated
@ferdymercury
ferdymercury marked this pull request as ready for review October 21, 2026 07:47
Co-authored-by: ferdymercury <ferdymercury@users.noreply.github.com>
@linev

linev commented Oct 21, 2026

Copy link
Copy Markdown
Member

In RBrowser.cxx there is wrong class name in the docu

One need to replace RWebWindowWindowsManager::CreateServer -> RWebWindowsManager::CreateServer

@ferdymercury
ferdymercury requested a review from linev October 21, 2026 08:33
@ferdymercury ferdymercury changed the title [webgui] fix 404 link [webgui] fix 404 link and typos Oct 21, 2026
@ferdymercury ferdymercury added this to the 6.42.00 milestone Oct 21, 2026

@linev linev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions

Copy link
Copy Markdown

Test Results

    22 files      22 suites   3d 4h 34m 40s ⏱️
 3 893 tests  3 874 ✅ 0 💤 19 ❌
72 232 runs  72 213 ✅ 0 💤 19 ❌

For more details on these failures, see this check.

Results for commit f6a12b2.

@linev
linev merged commit 65b4463 into root-project:master Oct 21, 2026
32 of 36 checks passed
@ferdymercury
ferdymercury deleted the patch-23 branch October 21, 2026 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr:squash on merge skip code analysis Skip the code analysis CI steps for this PR, including verifying clang-formatting and running Ruff.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants