Skip to content

Fix TDataMember::GetOptions() - #23773

Merged
linev merged 1 commit into
root-project:masterfrom
linev:fix_enum
Oct 21, 2026
Merged

linev merged 1 commit into
root-project:masterfrom
linev:fix_enum

Conversation

@linev

@linev linev commented Oct 20, 2026

Copy link
Copy Markdown
Member

When extract enum values - just directly try to find such value in correspondent TEnum. Not sure how this can be done using list of class data members.

Fixes #23772

One definitely need add test for the functionality

When extract enum values - just directly try to find such value in correspondent TEnum.
Not sure how this can be done using list of class data members.
@linev linev self-assigned this Oct 20, 2026
@linev
linev requested review from dpiparo and pcanal as code owners October 20, 2026 15:56
@github-actions

Copy link
Copy Markdown

Test Results

    24 files      24 suites   4d 2h 20m 33s ⏱️
 3 892 tests  3 891 ✅ 0 💤 1 ❌
83 325 runs  83 324 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit d422143.

Comment thread core/meta/src/TDataMember.cxx Resolved
Comment thread core/meta/src/TDataMember.cxx Resolved

@pcanal pcanal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@linev

linev commented Oct 21, 2026

Copy link
Copy Markdown
Member Author

@pcanal

Where will be right place to add testing for TDataMember::GetOptions()?
I just want to verify that options for TAttImage::fImageQuality returns correct result.
Because this member has tricky comments.
Maybe roottest/root/meta/enums?

@linev
linev merged commit 9604629 into root-project:master Oct 21, 2026
29 of 32 checks passed
@linev

linev commented Oct 21, 2026

Copy link
Copy Markdown
Member Author

/backport to 6.40

@linev
linev deleted the fix_enum branch October 21, 2026 05:18
@root-project-bot

Copy link
Copy Markdown

Preparing to backport PR #23773 to branch 6.40 requested by linev

@root-project-bot

Copy link
Copy Markdown

This PR has been backported to branch 6.40: #23778

@pcanal

pcanal commented Oct 21, 2026

Copy link
Copy Markdown
Member

Where will be right place to add testing for TDataMember::GetOptions()?
I just want to verify that options for TAttImage::fImageQuality returns correct result.
Because this member has tricky comments.
Maybe roottest/root/meta/enums?

That sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[meta] TDataMember::GetOptions() return wrong values for enum member

3 participants