Repository navigation
[core] Add essential unit tests for TOrdCollection - #23763
Open
ravindra-RKB wants to merge 3 commits into
Open
ravindra-RKB wants to merge 3 commits into
ravindra-RKB wants to merge 3 commits into
Conversation
ravindra-RKB
requested review from
bellenot,
dpiparo and
pcanal
as code owners
October 19, 2026 18:49
Test Results 23 files 23 suites 3d 11h 26m 54s ⏱️ For more details on these failures, see this check. Results for commit 5c066eb. |
pcanal
reviewed
Oct 19, 2026
| EXPECT_TRUE(col.IsEmpty()); | ||
| EXPECT_EQ(nullptr, col.First()); | ||
| EXPECT_EQ(nullptr, col.Last()); | ||
| EXPECT_EQ(nullptr, col.At(0)); |
Member
There was a problem hiding this comment.
When testing error cases that will issue an error message, please use ROOT::TestSupport::CheckDiagsRAII.
Contributor
Author
|
Updated! I have removed the unhandled illegal-index calls from |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces comprehensive unit tests for
TOrdCollectionincore/cont/test/TOrdCollectionTest.cxx.TOrdCollectionis an ordered sequence container backed by an array with gap-buffer semantics, actively used across ROOT subsystems. Previously, there was no dedicated Google Test coverage for it incore/cont/test.The new test suite covers:
AddFirst,AddLast,AddAt,AddBefore,AddAfter).PutAt).Remove,RemoveAt) across boundaries (head, middle, tail).First,Last,Before,After,IndexOf).Sort,BinarySearch).SetOwner,Clear,Delete).TIterandTOrdCollectionIter).Checklist
/W4 /WXwith zero warnings.