Repository navigation
[eve7] Fixes: two crashes, projection, camera placement, motion delivery - #23750
Merged
Merged
Conversation
- An element with a transformation but no render data, e.g. a group, crashed the server. BuildRenderData() now sets the matrix only when there is render data. - A projected line with no points crashed the server. REveLineProjected::SetDepthLocal() now loops over the points by index. Assisted-by: Claude:Opus 5.5
- A change with both a new colour and a new matrix lost the matrix. EveManager.ImportSceneChangeJson() now handles both. Assisted-by: Claude:Opus 5.5
- REveProjection::ProjectPointdv() gave wrong points when the input and the output were the same array. It now multiplies through a temporary. Added a gtest. - projection_axes.C now puts each projection manager in its projected scene. In EveWorld the client did not get the manager's updates. Assisted-by: Claude:Opus 5.5
- The camera could start inside the scene: its distance assumed a 30 degree field of view, and the camera has 75. The distance now follows the camera's field of view. - The first camera placement happens before the scenes exist. The camera is now placed again when the first content arrives. Assisted-by: Claude:Opus 5.5
- Motion updates were lost when a connection could not take a direct send. They now go out with the regular changes. - Removed the motion rate cap, REveViewer::SetMotionMaxHz(). It dropped updates over the rate. SetRenderMaxHz() still caps drawing. Assisted-by: Claude:Opus 5.5
Test Results 23 files 23 suites 3d 21h 16m 48s ⏱️ For more details on these failures, see this check. Results for commit 1c51de6. |
linev
approved these changes
Oct 19, 2026
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull request:
REve fixes found while working on bounding boxes (next PR). One commit per
topic.
Changes or fixes:
data, and a projected line with no points.
the same array.
arrives.
REveViewer::SetMotionMaxHz().
Checklist:
trans_update.C, boing.C, event_demo.C and motion delivery in a browser
Developed with AI assistance: Claude Code (Anthropic). The commits carry
the corresponding
Assisted-by:trailer.