Repository navigation
[ntuple] Move RNTupleProcessor out of Experimental - #23745
Merged
Merged
Conversation
Test Results 24 files 24 suites 4d 3h 2m 53s ⏱️ For more details on these failures, see this check. Results for commit 7ab5766. ♻️ This comment has been updated with latest results. |
enirolf
marked this pull request as ready for review
October 17, 2026 09:21
enirolf
requested review from
dpiparo,
hageboeck,
jblomer,
silverweed and
vepadulano
as code owners
October 17, 2026 09:21
jblomer
reviewed
Oct 19, 2026
jblomer
left a comment
jblomer
left a comment
Contributor
There was a problem hiding this comment.
In principle looks good. I am wondering about the RNTupleOpenSpec though. I wonder if there is a better name for it.
How about
RNTupleInputSpecRNTupleProcessorInput?
The first one may suggest that we want to use this class also for other classes (RNTupleReader, e.g.), in which case we should probably put it in the RNTupleTypes header.
enirolf
changed the title
* RNTupleProcessorProvenance * RNTupleProcessorEntry
enirolf
force-pushed
the
ntuple-proc-prod
branch
from
October 22, 2026 12:23
6002706 to
cb9a532
Compare
jblomer
approved these changes
Oct 22, 2026
jblomer
reviewed
Oct 22, 2026
.. and move it to `RNTupleTypes.hxx`
enirolf
force-pushed
the
ntuple-proc-prod
branch
from
October 23, 2026 08:31
cb9a532 to
7ab5766
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RNTupleTypes.hxx)As decided upfront, the RNTupleJoinProcessor remains in Experimental for the time being.