[jmcarcell]

This Pull request:

Changes or fixes:

The include directories of external dependencies used by a library are stored in the includePaths[] of its dictionary, and they are added to the interpreter when the library is loaded. When ROOT and its dependencies are built in one place and then relocated, these paths no longer exist but still show up in gSystem->GetIncludePath(). For example, in the LCG nightlies, ROOT and its dependencies are built under /build/jenkins/... and then deployed to CVMFS:

-I"/build/jenkins/workspace/lcg_nightly_pipeline/install/dev3/pcre2/10.49/x86_64-el9-gcc15-opt/include"
-I"/build/jenkins/workspace/lcg_nightly_pipeline/install/dev3/xxHash/0.8.3/x86_64-el9-gcc15-opt/include"
-I"/build/jenkins/workspace/lcg_nightly_pipeline/install/dev3/tbb/2023.1.0/x86_64-el9-gcc15-opt/include"
-I"/build/jenkins/workspace/lcg_nightly_pipeline/install/dev3/jsonmcpp/3.12.0/x86_64-el9-gcc15-opt/include"

This adds ROOT_DICTIONARY_EXCLUDE_PATHS, a list of path prefixes that are passed to rootcling as -excludePath, so that include paths under them are not stored in the dictionaries (let me know if there is a better way of doing this). They are still used for parsing when generating the dictionaries. This is only useful for builds that are relocated, where the dependencies are found at runtime through the environment of the final installation (e.g. ROOT_INCLUDE_PATH). Nothing changes when the variable is not set. For the case above, it would be -DROOT_DICTIONARY_EXCLUDE_PATHS=/build/jenkins/workspace/lcg_nightly_pipeline/install/dev3.

Together with #23704, which does the same for the ROOT build directory, no build paths are left in gSystem->GetIncludePath().

Checklist:

• tested changes locally
• updated the docs (if necessary)

[github-actions]

Test Results

    24 files      24 suites   4d 0h 30m 56s ⏱️
 3 888 tests  3 887 ✅ 0 💤 1 ❌
83 245 runs  83 244 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit f3bf7c7.

♻️ This comment has been updated with latest results.

[bellenot]

Thanks!

[jmcarcell]

ROOT in dev3 now doesn't show any paths to build directories after setting the installation prefix with this new variable:

-I/cvmfs/sft-nightlies.cern.ch/lcg/nightlies/dev3/Wed/ROOT/e18d7f98/x86_64-el9-gcc13-opt/include -I"/cvmfs/sft-nightlies.cern.ch/lcg/nightlies/dev3/Wed/jsonmcpp/3.12.0/x86_64-el9-gcc13-opt/include" -I"/cvmfs/sft-nightlies.cern.ch/lcg/nightlies/dev3/Wed/ROOT/e18d7f98/x86_64-el9-gcc13-opt/etc/" -I"/cvmfs/sft-nightlies.cern.ch/lcg/nightlies/dev3/Wed/ROOT/e18d7f98/x86_64-el9-gcc13-opt/etc//cling" -I"/cvmfs/sft-nightlies.cern.ch/lcg/nightlies/dev3/Wed/ROOT/e18d7f98/x86_64-el9-gcc13-opt/etc//cling/plugins/include" -I"/cvmfs/sft-nightlies.cern.ch/lcg/nightlies/dev3/Wed/ROOT/e18d7f98/x86_64-el9-gcc13-opt/include"

[bellenot]

ROOT in dev3 now doesn't show any paths to build directories after setting the installation prefix with this new variable:

-I/cvmfs/sft-nightlies.cern.ch/lcg/nightlies/dev3/Wed/ROOT/e18d7f98/x86_64-el9-gcc13-opt/include -I"/cvmfs/sft-nightlies.cern.ch/lcg/nightlies/dev3/Wed/jsonmcpp/3.12.0/x86_64-el9-gcc13-opt/include" -I"/cvmfs/sft-nightlies.cern.ch/lcg/nightlies/dev3/Wed/ROOT/e18d7f98/x86_64-el9-gcc13-opt/etc/" -I"/cvmfs/sft-nightlies.cern.ch/lcg/nightlies/dev3/Wed/ROOT/e18d7f98/x86_64-el9-gcc13-opt/etc//cling" -I"/cvmfs/sft-nightlies.cern.ch/lcg/nightlies/dev3/Wed/ROOT/e18d7f98/x86_64-el9-gcc13-opt/etc//cling/plugins/include" -I"/cvmfs/sft-nightlies.cern.ch/lcg/nightlies/dev3/Wed/ROOT/e18d7f98/x86_64-el9-gcc13-opt/include"

Should we revert the commit then?

[jmcarcell]

No, that was the point of this change, not to have includes to build paths that don't exist anymore (for us, the /build/jenkins...). I'm just confirming that I checked it seems to work as intended.

[bellenot]

No, that was the point of this change, not to have includes to build paths that don't exist anymore (for us, the /build/jenkins...). I'm just confirming that I checked it seems to work as intended.

Oh! OK, sorry... And thanks for the feedback then!