Skip to content

[ntuple] fix emulatation of SoA fields - #23698

Merged
jblomer merged 1 commit into
root-project:masterfrom
jblomer:ntuple-fix-soa-emulation
Oct 23, 2026
Merged

jblomer merged 1 commit into
root-project:masterfrom
jblomer:ntuple-fix-soa-emulation

Conversation

@jblomer

@jblomer jblomer commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Emulated SoA fields should have the SoA trait set so that during merging the output field preserves the flag.

@jblomer
jblomer requested review from enirolf, hahnjo and pcanal October 13, 2026 09:31
@jblomer jblomer self-assigned this Oct 13, 2026
@jblomer
jblomer requested a review from silverweed as a code owner October 13, 2026 09:31
@jblomer
jblomer force-pushed the ntuple-fix-soa-emulation branch from 32357ba to 25a9f9b Compare October 13, 2026 09:37
@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Test Results

    24 files      24 suites   4d 1h 20m 58s ⏱️
 3 892 tests  3 890 ✅ 0 💤 2 ❌
83 350 runs  83 348 ✅ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit e893dbb.

♻️ This comment has been updated with latest results.

@jblomer

jblomer commented Oct 14, 2026

Copy link
Copy Markdown
Contributor Author

Should be rebased on top of #23702

@jblomer
jblomer force-pushed the ntuple-fix-soa-emulation branch from 25a9f9b to e893dbb Compare October 22, 2026 19:47
Emulated SoA fields should have the SoA trait set so that during
merging the output field preserves the flag.

@enirolf enirolf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm :)

@jblomer
jblomer merged commit a2a0f42 into root-project:master Oct 23, 2026
33 of 36 checks passed
@jblomer
jblomer deleted the ntuple-fix-soa-emulation branch October 23, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants