Skip to content

Revert "[tmva][sofie] Pass senders/receivers as int64_t pointers in GNN tutorial" - #23580

Open
guitargeek wants to merge 1 commit into
root-project:masterfrom
guitargeek:sofie-fixup
Open

guitargeek wants to merge 1 commit into
root-project:masterfrom
guitargeek:sofie-fixup

Conversation

@guitargeek

@guitargeek guitargeek commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

This reverts commit guitargeek@bb5fa27.

The conversion of numpy int64 arrays to 'const int64_t*' parameters is now fixed in cppjit itself as of 45c723f, so the explicit cppyy.ll.cast workaround is not needed anymore. The tutorial passes the numpy arrays directly again.

@github-actions

github-actions Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Test Results

    24 files      24 suites   3d 21h 38m 6s ⏱️
 3 896 tests  3 895 ✅ 0 💤 1 ❌
83 413 runs  83 412 ✅ 0 💤 1 ❌

For more details on these failures, see this check.

Results for commit 4607024.

♻️ This comment has been updated with latest results.

…NN tutorial"

This reverts commit bb5fa27.

The conversion of numpy int64 arrays to 'const int64_t*' parameters is
now fixed in cppjit itself as of 45c723f, so the explicit
`cppyy.ll.cast workaround` is not needed anymore. The tutorial passes
the numpy arrays directly again.
@guitargeek guitargeek changed the title [cppyy] Treat long and long long buffer formats as interchangeable Revert "[tmva][sofie] Pass senders/receivers as int64_t pointers in GNN tutorial" Oct 24, 2026
@guitargeek guitargeek removed the bug label Oct 24, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant