Skip to content

[core] ACLiC: skip dependency scan for explicitly linked libraries #23538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
guitargeek wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[core] ACLiC: skip dependency scan for explicitly linked libraries #23538

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions core/base/src/TSystem.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3418,16 +3418,18 @@ int TSystem::CompileMacro(const char *filename, Option_t *opt,
if (!f(I->c_str()))
break;
};
auto LoadLibrary = [useCxxModules, produceRootmap, ForeachSharedLibDep](const TString &lib) {
// We have no rootmap files or modules to construct `-l` flags enabling
// explicit linking. We have to resolve the dependencies by ourselves
// taking the job of the dyld.
auto LoadLibrary = [linkDepLibraries, useCxxModules, produceRootmap, ForeachSharedLibDep](const TString &lib) {

@pcanal pcanal Sep 29, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only semantic problem I see here is that 'linkDepLibraries' is about how we will construct the upcoming library and not whether the library we are linking against are all fully explicitly linked :( ..

@dpiparo dpiparo Sep 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should it be maybe called preLoadDepLibraries instead?

@pcanal pcanal Sep 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean?

@dpiparo dpiparo Oct 3, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to address with minimal changes your comment I think

@pcanal pcanal Oct 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might not have been clear. The flag linkDepLibraries only change how the ACLiC libraries are generated, however it does not tell anything about any other libraries. Thus for a given library in the list we still don't know if the deep search is needed or not as that library might or might be explicitly linked to its dependencies.

// If the library was explicitly linked against its dependencies, they
// are recorded in the library itself and the dynamic linker loads them.
// Otherwise, we have no rootmap files or modules to construct `-l` flags
// enabling explicit linking. We have to resolve the dependencies by
// ourselves taking the job of the dyld.
// FIXME: This is a rare case where we have rootcling running with
// modules disabled. Remove this code once we fully switch to modules,
// or implement a special flag in rootcling which selective enables
// modules for dependent libraries and does not produce a module for
// the ACLiC library.
if (useCxxModules && !produceRootmap) {
if (!linkDepLibraries && useCxxModules && !produceRootmap) {
std::function<bool(const char *)> LoadLibF = [](const char *dep) {
return gInterpreter->Load(dep, /*skipReload*/ true) >= 0;
};
Expand Down
Loading