Skip to content

Conversation

@dpiparo
Copy link
Member

@dpiparo dpiparo commented Jan 9, 2026

No description provided.

@dpiparo dpiparo self-assigned this Jan 9, 2026
@dpiparo dpiparo requested a review from jblomer January 9, 2026 13:09
@github-actions
Copy link

github-actions bot commented Jan 9, 2026

Test Results

    23 files      23 suites   4d 9h 38m 8s ⏱️
 3 813 tests  3 811 ✅ 0 💤 2 ❌
80 378 runs  80 376 ✅ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit 5728132.

♻️ This comment has been updated with latest results.

@dpiparo dpiparo force-pushed the rootbench_clone branch 2 times, most recently from 71e6445 to a18bd7a Compare January 9, 2026 15:04
@ferdymercury
Copy link
Collaborator

ferdymercury commented Jan 9, 2026

Cool thanks. A-bit-related-potentially-useful feature: root-project/rootbench#192 (https://its.cern.ch/jira/browse/ROOT-10181)

Fixes https://its.cern.ch/jira/browse/ROOT-10185

@dpiparo
Copy link
Member Author

dpiparo commented Jan 9, 2026

Thanks for the comment, @ferdymercury !
You are right. This is the very first step towards the ambitious goals you list. We need first to revive rootbench, building and running it regularly. Some discussion will be needed about how we intend to address all the other requirements of a system for continuous performance monitoring, but the direction is clear :)

@ferdymercury
Copy link
Collaborator

Thanks for the info and the great initiative!
One related question from my side: do you have plans in the future to merge rootbench with root as you did with roottest? I guess this will be much easier here since it's a very small git repo, and would potentially help for keeping it maintained.

@dpiparo
Copy link
Member Author

dpiparo commented Jan 9, 2026

This is a smart question. We are discussing how to proceed. In principle you are right, however some components of rootbench, for example the cmake code or the way in which workflows are invoked from within C++, could be difficult to port as they are into ROOT as it is today. However, the value of the individual benchmarks and the idea of rootbench is still high for the project, we'll have to pragmatically converge towards a way to preserve it in the modern ROOT.

the master branch of the rootbench repo is cloned outside of
ROOT's build directory.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants