Skip to content

Default to selecting all for event stream#194

Merged
haileyok merged 1 commit intoroostorg:mainfrom
chimosky:select-all
Mar 30, 2026
Merged

Default to selecting all for event stream#194
haileyok merged 1 commit intoroostorg:mainfrom
chimosky:select-all

Conversation

@chimosky
Copy link
Copy Markdown
Contributor

Description

All features are now selected by default, the existing behavior still works as expected.

I did this because for some reason, it seems setting defaultChecked to true on each checkBox doesn't work.

Fixes #126

@cassidyjames kindly review.

Checklist

  • Tests pass locally
  • uv run ruff check . passes (no unused imports or other lint errors)
  • uv tool run fawltydeps --check-unused --pyenv .venv passes (no unused dependencies)

Comment thread osprey_ui/src/components/event_stream/FeatureSelectModal.tsx Outdated
Copy link
Copy Markdown
Collaborator

@haileyok haileyok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do you mind removing the uv.lock changes as well as updating the CHANGELOG.md? (we need to put something in the pr template that talks about the changelog, sorry about that)

@chimosky
Copy link
Copy Markdown
Contributor Author

do you mind removing the uv.lock changes as well as updating the CHANGELOG.md? (we need to put something in the pr template that talks about the changelog, sorry about that)

Removed, wouldn't it be great to add uv.lock to gitignore if it's not something that should change very often?

Is my entry in CHANGELOG.md what's expected?

@haileyok
Copy link
Copy Markdown
Collaborator

Is my entry in CHANGELOG.md what's expected?

yep, ty!!

Removed, wouldn't it be great to add uv.lock to gitignore if it's not something that should change very often?

unfortunately we need to keep it committed so that library versions stay pinned between builds and deployments. i think if you use uv sync --frozen it will prevent the uv.lock from being modified

@chimosky chimosky force-pushed the select-all branch 2 times, most recently from 9f8046e to a6e6f60 Compare March 27, 2026 09:04
@chimosky
Copy link
Copy Markdown
Contributor Author

chimosky commented Mar 27, 2026

unfortunately we need to keep it committed so that library versions stay pinned between builds and deployments. i think if you use uv sync --frozen it will prevent the uv.lock from being modified

The development docs would be a great place to include this, seeing as it contains most of such information.

I can open a PR for it.

Sorry for the notification hell.

All features are now selected by default, the existing behavior still works as expected.

I did this because for some reason, it seems setting defaultChecked to true on each checkBox doesn't work.

Signed-off-by: Chihurumnaya Ibiam <ibiamchihurumnaya@gmail.com>
@haileyok
Copy link
Copy Markdown
Collaborator

The development docs would be a great place to include this, seeing as it contains most of such information.

ya, def feel free to open a PR, thank you!!

no worries on the notifs <3

@haileyok haileyok merged commit 509d3a9 into roostorg:main Mar 30, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Default to selecting all for event stream

2 participants