Open
Conversation
Contributor
Author
|
This PR suffers from the same issue as #74 (missing Vite configuration in Docker build context). I'll rebase it on current |
pawiecz
force-pushed
the
migrate-to-apollo-v5
branch
from
739d331 to
27505f4
Compare
pawiecz
requested review from
cassidyjames,
dom-notion,
juanmrad,
julietshen and
vinaysrao1
as code owners
vinaysrao1
requested changes
Apr 3, 2026
Contributor
vinaysrao1
left a comment
vinaysrao1
left a comment
There was a problem hiding this comment.
Minor requests only. this is a clean and methodically done PR. Well done.
| ); | ||
|
|
||
| Object.entries(controllers).forEach(([_k, controller]) => { | ||
| controller.routes.forEach((it) => { |
| "@googlemaps/google-maps-services-js@^3.3.16": { | ||
| "retry-axios": "npm:@ethanresnick/retry-axios@2.6.1" | ||
| }, | ||
| "apollo-server-express": { |
juanmrad
requested changes
Apr 4, 2026
| message: sanitizedErrorTitle, | ||
| extensions, | ||
| }; | ||
| } as unknown as GraphQLFormattedError; |
Member
There was a problem hiding this comment.
do we need double casting here?
| const user = context.getUser(); | ||
| if (!user || !user.orgId) { | ||
| throw new AuthenticationError('User must be authenticated'); | ||
| throw new GraphQLError('User must be authenticated', { extensions: { code: 'UNAUTHENTICATED' } }); |
Member
There was a problem hiding this comment.
These should be FORBIDDEN instead
| const user = context.getUser(); | ||
| if (!user || !user.orgId) { | ||
| throw new AuthenticationError('User must be authenticated'); | ||
| throw new GraphQLError('User must be authenticated', { extensions: { code: 'UNAUTHENTICATED' } }); |
Member
There was a problem hiding this comment.
maybe we should move all these to helper functions similar to what we had. where we just pass the message.
function unauthenticatedError(msg: string) {
return new GraphQLError(msg, { extensions: { code: 'UNAUTHENTICATED' } });
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context & Requests for Reviewers
Fixes: #67
Tests