Repository navigation
docs(#8): add testing and type annotation conventions - #9
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Add three convention bullets to the Conventions section of AGENTS.md to guide code agents on consistent practices: - Return type annotations required on all functions, including -> None for void functions - Test naming pattern: test_<function_name>_<behavior> - Test run command: uv run pytest tests/ -v These conventions codify patterns established in PR #7 and prevent review-fix cycles for naming inconsistency and missing annotation findings. Closes #8
|
🤖 Finished Review · ✅ Success · Started 9:20 PM UTC · Completed 9:31 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.56 |
|
Risk Assessment: low (1/5) DetailsMinimal-risk documentation-only PR adding 3 lines to AGENTS.md by a bot, with exact issue scope alignment and no security, CI, or dependency changes; the sole elevated signal is the protected-path flag on AGENTS.md. |
ReviewFindingsMedium
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-> None)test_<function_name>_<behavior>naming patternuv run pytest tests/ -vTesting
uv run pytest tests/ -v— all 4 tests passCloses #8
Post-script verification
agent/8-add-testing-type-conventions)e9bff5bd6e49cc49d4dde6cd09206e40532e9aea..HEAD)