Skip to content

[FEAT] Pretty check - #11

Closed
Wilovy09 wants to merge 4 commits into
romancitodev:mainfrom
Wilovy09:feat/cargo_pretty_check
Closed

Wilovy09 wants to merge 4 commits into
romancitodev:mainfrom
Wilovy09:feat/cargo_pretty_check

Conversation

@Wilovy09

@Wilovy09 Wilovy09 commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Wilovy09 and others added 4 commits November 4, 2026 17:09
The dependabot bump moved the direct colorgrad dependency to 0.9 while
nobubbles still builds against 0.8, so `Ramp::new` rejected the gradient
(E0277) and the crate stopped compiling. Pulling colorgrad through
nobubbles' re-export keeps both on the same version by construction.
`check` runs through the same pipeline as `build`: same JSON stream, unit
graph and warning panel, with nothing to run once it succeeds.

cargo reports most units as "Checking" under `check`, while build scripts
and proc-macros still say "Compiling", so the stderr parser now accepts
both; otherwise the in-flight list would stay empty for the whole run.

On-screen labels (live/done headers, progress bar, summary, warning panel)
now come from `Verb::wording()`, so `check` says "Checking"/"checked"
instead of claiming it built anything.
`ok` only flipped on a `BuildFinished` message, which cargo never emits
when it dies early (bad CLI args, unreadable manifest). Those runs were
reported as successful builds with 0 libs. The exit status now decides.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
`cargo-pretty -- check` read `--` as a flag, defaulted to build and
forwarded `check` to cargo, running `cargo build -- check`.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Wilovy09 Wilovy09 closed this Nov 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant