Add theme handling to all pages#971
Conversation
frank-weinberg
left a comment
frank-weinberg
left a comment
There was a problem hiding this comment.
There may be other instances of breaking compatibility. These are the ones I noticed on first reading.
Also: Can we please establish that (parts of) contributions that are generated by AI are flagged as such in the PR? That affects what to focus on in a review since there are some types of errors that are more likely for AI and others that are more likely for humans.
(This PR has some typical indicators of AI code and IIRC you have in the past stated that you're not a programmer, so I'm guessing it's AI. But I'd prefer to know instead of speculating.)
| return href; | ||
| } | ||
|
|
||
| let url; |
There was a problem hiding this comment.
let breaks compatibility with older iPads
| $(function () { | ||
| _propagateThemeToLinks(document); | ||
|
|
||
| const themeLinkObserver = new MutationObserver(function (mutations) { |
There was a problem hiding this comment.
MutationObserver breaks compatibility with older iPads
|
|
||
| // Do not alter links to non URLs. | ||
| if ( | ||
| trimmedHref.startsWith('#') || |
There was a problem hiding this comment.
startsWith breaks compatibility with older iPads
|
Thanks @frank-weinberg - confirming this is an AI update. I'll review further regarding backwards compatability for the older iPads |
2 participants
Proposal to resolve #970