feat: add savings goals tracking with milestones#828
Open
liufang88789-ui wants to merge 1 commit intorohitdash08:mainfrom
Open
feat: add savings goals tracking with milestones#828liufang88789-ui wants to merge 1 commit intorohitdash08:mainfrom
liufang88789-ui wants to merge 1 commit intorohitdash08:mainfrom
Conversation
- Backend: SavingsGoal + SavingsMilestone models (packages/backend/app/models.py) - Backend: CRUD + contribute endpoint (packages/backend/app/routes/savings.py) - Backend: Blueprint registered at /savings - Backend: Tests covering CRUD, milestones, auth guards, validation - Frontend: api/savings.ts client module - Frontend: Savings.tsx full page (list, create, contribute, milestones) - Frontend: Navbar + route added for /savings - Closes rohitdash08#133
Author
|
Hi @rohitdash08 — just a quick check-in on this PR. The savings goals & milestones implementation is complete and all checks are passing. Ready for review whenever you have a moment. Let me know if you'd like any adjustments! Bounty hunter: liufang88789-ui |
Author
|
Hi @rohitdash08 — quick follow-up on PR #828. I’ve already included
I can share a short demo video as well if that helps review. If you'd prefer a smaller scope or a narrower version of the feature first, I’m happy to adjust the PR accordingly. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements goal-based savings tracking with milestone support as requested in issue #133.
Changes
Backend
packages/backend/app/models.py):SavingsGoalandSavingsMilestonepackages/backend/app/routes/savings.py): full REST API for savings goals/savingspackages/backend/tests/test_savings.py): CRUD, milestones, auth guards, validationFrontend
app/src/api/savings.ts): typed client for all savings endpointsapp/src/pages/Savings.tsx): full page with goal management and milestonesTest Coverage
Claim
/claim #133
Closes #133