WIP, grouping occurrences by the grouped artifact for git resources#102
Draft
pickjasmine wants to merge 5 commits intomainfrom
Draft
WIP, grouping occurrences by the grouped artifact for git resources#102pickjasmine wants to merge 5 commits intomainfrom
pickjasmine wants to merge 5 commits intomainfrom
Conversation
Contributor
Author
|
Had some discussions on 06/03 around this. Seems like the grouping by produced artifact is needed. With the possibility of tfsec scans producing a build occurrence, the current logic might not work because this logic is looking for the built artifacts, and the built artifact is the same git resource or ??TBD. I'm going to leave this in draft until more thoughts are gathered around how to handle tfsec stuff. |
…at mobile-friendly styles but word breaks need some work
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to group together the occurrences related to a produced artifact, this is the code. Definitely could use some refactoring but I don't think this will end up being much smaller than it currently is. Testing is also going to be a nightmare with this, so I just want to push this out and see what we think before I commit to the whole ordeal.