Skip to content

Remove spaces from role names #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexashley merged 1 commit into from
Jul 15, 2021
Merged

Remove spaces from role names #68

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tf/modules/keycloak/roles.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ resource "keycloak_role" "demo_role" {
for_each = local.roles
realm_id = keycloak_realm.rode_demo.id
client_id = keycloak_openid_client.rode.id
name = each.key
name = replace(each.key, " ", "")
Copy link
Copy Markdown
Contributor

@mrparkers mrparkers Jul 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd probably just modify the local.roles variable instead of doing this, since it would reflect the actual strings that rode is expecting

Copy link
Copy Markdown
Contributor Author

@alexashley alexashley Jul 15, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left the local variable as-is since it's also used to create users and groups. We could keep have the user accounts all named after the role (PolicyAdministrator), but right now they're lower-case and hyphenated: policy-administrator.

I could go either way, but that's why I just changed the name in the role.

Copy link
Copy Markdown
Contributor

@mrparkers mrparkers Jul 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, it's probably fine then

}

resource "keycloak_group" "demo_group" {
Expand Down