Skip to content

fix(report): align PackageListEntry field names with PackageEntry #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rocketman-code wants to merge 1 commit into from
Closed

fix(report): align PackageListEntry field names with PackageEntry #159

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions src/report.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,8 +356,8 @@ pub struct PackagesReport {
#[derive(Debug, Clone, Serialize)]
pub struct PackageListEntry {
pub name: String,
pub size: u64,
pub files: u32,
pub total_size_bytes: u64,
pub file_count: u32,
}

// ---------------------------------------------------------------------------
Expand Down Expand Up @@ -849,9 +849,9 @@ impl PackagesReport {
out,
" {:<40} {:>8} {} file{}",
pkg.name,
format_size(pkg.size),
pkg.files,
plural(u64::from(pkg.files))
format_size(pkg.total_size_bytes),
pkg.file_count,
plural(u64::from(pkg.file_count))
)
.unwrap();
}
Expand Down Expand Up @@ -1027,15 +1027,15 @@ mod tests {
package_count: 2,
packages: vec![PackageListEntry {
name: "zod".into(),
size: 500,
files: 3,
total_size_bytes: 500,
file_count: 3,
}],
};
let json: serde_json::Value = serde_json::from_str(&report.to_json()).unwrap();
assert_eq!(json["package_count"], 2);
assert_eq!(json["packages"][0]["name"], "zod");
assert_eq!(json["packages"][0]["size"], 500);
assert_eq!(json["packages"][0]["files"], 3);
assert_eq!(json["packages"][0]["total_size_bytes"], 500);
assert_eq!(json["packages"][0]["file_count"], 3);
}

#[test]
Expand Down
4 changes: 2 additions & 2 deletions src/session.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -538,8 +538,8 @@ impl Session {
.iter()
.map(|pkg| PackageListEntry {
name: pkg.name.clone(),
size: pkg.total_reachable_size,
files: pkg.total_reachable_files,
total_size_bytes: pkg.total_reachable_size,
file_count: pkg.total_reachable_files,
})
.collect(),
}
Expand Down