fix(session): prevent false direct_import for nonexistent targets#157
Closed
rocketman-code wants to merge 1 commit intomainfrom
Closed
fix(session): prevent false direct_import for nonexistent targets#157rocketman-code wants to merge 1 commit intomainfrom
rocketman-code wants to merge 1 commit intomainfrom
Conversation
3 tasks
Owner
Author
|
Closing: the fix (commit 94d90c1) is already on main. The branch is based on a stale main and would be empty after rebase. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
--cutis used with a target that doesn't exist in the graph, thedirect_importfield in the report incorrectly returnstrue. This happens because the checkcuts.is_empty() && chains.iter().all(|c| c.len() == 2)vacuously evaluates totruewhen bothcutsandchainsare empty.The fix adds a
!chains.is_empty()guard sodirect_importis onlytruewhen there are actual import chains confirming a direct dependency.Closes #151