[rfc] Add simple snapcraft.yaml to package CLI#131
Open
zsol wants to merge 1 commit intorocket-pool:beta-3from
Open
[rfc] Add simple snapcraft.yaml to package CLI#131zsol wants to merge 1 commit intorocket-pool:beta-3from
zsol wants to merge 1 commit intorocket-pool:beta-3from
Conversation
Contributor
|
This is nice! I vote for option 2. |
kidkal
approved these changes
May 1, 2021
Author
|
I also think option 2 would make the most sense. I can make a followup PR to implement it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a build config for snapcraft. The package contains the three binaries (CLI, service, pow proxy) plus a curl binary. To build, run
snapcraftfrom the repo root on a box withsnapcraftinstalled. This will produce a developer mode.snapfile that can be installed withsudo snap install rocketpool_1.0.0-beta.1+git39.5596c3d_amd64.snap --classic --dangerous, which puts the CLI at/snap/bin/rocketpool.The main benefit of this approach is that users don't have to manually download binaries from github, make sure checksums match, and set up their environment with
$HOME/binetc.There are two ways we can proceed:
curlandtarwithxzsupport as far as i can tell). If we go this route, I'll remove the pow-proxy and service binaries, and addtar.service install:docker,docker-compose, and the config files. Doing this would mean the entire install/upgrade process can be handled bysnap- later on we can isolate the entire rocketpool installation so it can only access certain system resources (like the docker socket)