merge in wise/master, update bedrock commit to sqlite 3.51#23
Merged
merge in wise/master, update bedrock commit to sqlite 3.51#23
Conversation
Co-authored-by: mceachen <216377+mceachen@users.noreply.github.com>
* update node-abi * added switch for latest v8 api due to deprecation of context->GetIsolate * added Electron v39 to prebuilds * fix typo * use GetPrototypeV2 on v8 API version 13+
* chore(build): Add support for Electron 39+ builds in CI workflow by running those prebuilds with bookworm (and keeping the older prebuilds on bullseye). Fixes #1421 * chore(build): add support for node 25 (see #1412)
chore(build): add OIDC permissions and upgrade npm for trusted publishing
Co-authored-by: mceachen <216377+mceachen@users.noreply.github.com>
Co-authored-by: mceachen <216377+mceachen@users.noreply.github.com>
… (#1438) * chore(build.yml): Update Electron build command to include version 40.0.0 * chore: Add EOL date for v40
fix: update node-abi version in package.json to ^4.25.0
* Fix Node v25 errors on tests * Disable fail-fast on test jobs
Co-authored-by: mceachen <216377+mceachen@users.noreply.github.com>
* Revert "Fix Node v25 test errors (#1454)" This reverts commit 128cdf4. * ci: disable fail-fast in test job strategy
…456) fix: use Holder() instead of This() in PropertyCallbackInfo contexts PropertyCallbackInfo::This() was removed in V8 13.x (Electron 41), causing compilation errors in NODE_GETTER functions.
Co-authored-by: mceachen <216377+mceachen@users.noreply.github.com>
* Requires Node.js v20 or later * generic wording * link
Co-authored-by: mceachen <216377+mceachen@users.noreply.github.com>
fix: use HolderV2() for PropertyCallbackInfo on V8 >= 13 PR #1456 replaced This() with Holder() in NODE_GETTER contexts, but Electron 41 (V8 14.6) removed both This() and Holder() from PropertyCallbackInfo. Only HolderV2() remains (to be renamed back to Holder() in a future V8 version per crbug.com/333672197). Add a PROPERTY_HOLDER compat macro that uses HolderV2() on V8 >= 13 and falls back to This() on older versions. Same pattern as the existing GET_PROTOTYPE macro. Verified: compiles and runs on Electron 41.0.1 (V8 14.6.202). Fixes #1458
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also updated
download.shto pull SQLite 3.51 from the bedrock branch: https://sqlite.org/src/info/0e862bc9ed7aa9ae