Skip to content

chore(zql): Optimize join#5799

Merged
arv merged 6 commits intomainfrom
arv/join-less-alloc
Apr 14, 2026
Merged

chore(zql): Optimize join#5799
arv merged 6 commits intomainfrom
arv/join-less-alloc

Conversation

@arv
Copy link
Copy Markdown
Contributor

@arv arv commented Apr 10, 2026

Get rid of one allocation in every join push

@arv arv requested a review from tantaman April 10, 2026 15:29
@vercel
Copy link
Copy Markdown

vercel bot commented Apr 10, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
replicache-docs Ready Ready Preview, Comment Apr 14, 2026 0:31am
zbugs Ready Ready Preview, Comment Apr 14, 2026 0:31am

Request Review

@arv
Copy link
Copy Markdown
Contributor Author

arv commented Apr 10, 2026

also adds summary to bench

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 10, 2026

🐰 Bencher Report

Brancharv/join-less-alloc
TestbedLinux
Click to view all benchmark results
BenchmarkFile SizeBenchmark Result
kilobytes (KB)
(Result Δ%)
Upper Boundary
kilobytes (KB)
(Limit %)
zero-package.tgz📈 view plot
🚷 view threshold
1,995.67 KB
(-0.01%)Baseline: 1,995.80 KB
2,035.71 KB
(98.03%)
zero.js📈 view plot
🚷 view threshold
269.13 KB
(-0.05%)Baseline: 269.27 KB
274.65 KB
(97.99%)
zero.js.br📈 view plot
🚷 view threshold
71.75 KB
(-0.03%)Baseline: 71.77 KB
73.21 KB
(98.01%)
🐰 View full continuous benchmarking report in Bencher

@github-actions
Copy link
Copy Markdown

🐰 Bencher Report

Brancharv/join-less-alloc
TestbedLinux
Click to view all benchmark results
BenchmarkFile SizeBenchmark Result
kilobytes (KB)
(Result Δ%)
Upper Boundary
kilobytes (KB)
(Limit %)
zero-package.tgz📈 view plot
🚷 view threshold
1,988.20 KB
(-0.01%)Baseline: 1,988.35 KB
2,028.12 KB
(98.03%)
zero.js📈 view plot
🚷 view threshold
270.10 KB
(-0.05%)Baseline: 270.24 KB
275.64 KB
(97.99%)
zero.js.br📈 view plot
🚷 view threshold
71.62 KB
(-0.06%)Baseline: 71.67 KB
73.10 KB
(97.98%)
🐰 View full continuous benchmarking report in Bencher

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 10, 2026

🐰 Bencher Report

Brancharv/join-less-alloc
Testbedself-hosted-metal
Click to view all benchmark results
BenchmarkThroughputBenchmark Result
operations / second (ops/s)
(Result Δ%)
Lower Boundary
operations / second (ops/s)
(Limit %)
src/db/pg-copy.bench.ts > pg-copy benchmark > copy📈 view plot
🚷 view threshold
23.61 ops/s
(+0.05%)Baseline: 23.60 ops/s
22.12 ops/s
(93.67%)
🐰 View full continuous benchmarking report in Bencher

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 10, 2026

🐰 Bencher Report

Brancharv/join-less-alloc
Testbedself-hosted-metal

⚠️ WARNING: Truncated view!

The full continuous benchmarking report exceeds the maximum length allowed on this platform.

🚨 25 Alerts

🐰 View full continuous benchmarking report in Bencher

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 10, 2026

🐰 Bencher Report

Brancharv/join-less-alloc
Testbedself-hosted-metal

⚠️ WARNING: Truncated view!

The full continuous benchmarking report exceeds the maximum length allowed on this platform.

🚨 19 Alerts

🐰 View full continuous benchmarking report in Bencher

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 10, 2026

🐰 Bencher Report

Brancharv/join-less-alloc
Testbedself-hosted-metal
Click to view all benchmark results
BenchmarkThroughputBenchmark Result
operations / second (ops/s) x 1e3
(Result Δ%)
Lower Boundary
operations / second (ops/s) x 1e3
(Limit %)
src/client/custom.bench.ts > big schema📈 view plot
🚷 view threshold
100.40 ops/s x 1e3
(-8.34%)Baseline: 109.53 ops/s x 1e3
90.19 ops/s x 1e3
(89.84%)
src/client/zero.bench.ts > basics > All 1000 rows x 10 columns (numbers)📈 view plot
🚷 view threshold
1.62 ops/s x 1e3
(-0.44%)Baseline: 1.63 ops/s x 1e3
1.48 ops/s x 1e3
(91.34%)
src/client/zero.bench.ts > pk compare > pk = N📈 view plot
🚷 view threshold
36.99 ops/s x 1e3
(-0.09%)Baseline: 37.02 ops/s x 1e3
34.15 ops/s x 1e3
(92.33%)
src/client/zero.bench.ts > with filter > Lower rows 500 x 10 columns (numbers)📈 view plot
🚷 view threshold
2.17 ops/s x 1e3
(+0.19%)Baseline: 2.16 ops/s x 1e3
1.83 ops/s x 1e3
(84.35%)
🐰 View full continuous benchmarking report in Bencher

@arv arv force-pushed the arv/join-less-alloc branch from 947fa13 to 32fcfd6 Compare April 13, 2026 14:10
@arv arv added this pull request to the merge queue Apr 13, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 13, 2026
@arv arv added this pull request to the merge queue Apr 13, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 13, 2026
@arv arv added this pull request to the merge queue Apr 13, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 13, 2026
@arv arv added this pull request to the merge queue Apr 14, 2026
Merged via the queue into main with commit 327ae6d Apr 14, 2026
30 of 36 checks passed
@arv arv deleted the arv/join-less-alloc branch April 14, 2026 14:13
arv added a commit that referenced this pull request Apr 17, 2026
Get rid of one allocation in every join push
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant