Skip to content

Controls update - #2

Merged
koolpoolo merged 5 commits into
mainfrom
drivebase_fixes
Sep 18, 2026
Merged

koolpoolo merged 5 commits into
mainfrom
drivebase_fixes

Conversation

@koolpoolo

Copy link
Copy Markdown
Contributor

i forgot to add stuff in drivebase controls

@markpete markpete left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on a first draft. Please consider the following potential issues and let me know your thoughts.

Comment thread src/main/java/frc/robot/Controls.java Outdated
Comment thread src/main/java/frc/robot/Controls.java Outdated
Comment thread src/main/java/frc/robot/Controls.java
Comment thread src/main/java/frc/robot/Controls.java
Comment thread src/main/java/frc/robot/Controls.java
@markpete

Copy link
Copy Markdown

/review

@qodo-code-review

Copy link
Copy Markdown

PR Reviewer Guide 🔍

Warning

/review is deprecated. Use /agentic_review instead (removal date not yet scheduled).

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Command Conflict

The brake command created with Commands.run does not require drivebaseSubsystem, so the default drive command can continue sending velocity requests while the brake command sends brake requests. Add the subsystem as a requirement or use its command factory to ensure the default command is interrupted.

driverController
    .a()
    .whileTrue(Commands.run(() -> s.drivebaseSubsystem.setControl(new SwerveDriveBrake())));

@koolpoolo
koolpoolo merged commit efd7618 into main Sep 18, 2026
2 checks passed
@koolpoolo
koolpoolo deleted the drivebase_fixes branch September 18, 2026 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants