Repository navigation
Conversation
Keep the one-sided combine payload at a fixed workspace offset when dispatch precision or token count changes. Validate dispatch bounds before native writes and use the same offset for direct-to-workspace outputs. Preserve the existing workspace allocation policy and add layout checks and a four-rank mixed-layout regression. Signed-off-by: bofengluo <bofengl@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The one-sided MoE combine offset previously depended on the current dispatch
payload size. Changes in payload precision or token count could let a later
dispatch overwrite the previous combine payload while a peer was still reading it.
This change:
The existing workspace allocation policy is unchanged.
Test Coverage
detection, insufficient capacity, incompatible combine layouts, and lazy
reservation for both CFT and non-CFT workspaces.
workspace state.
empty local ranks, eager execution/CUDA graphs, CFT/non-CFT paths,
low-precision combine, and direct-to-workspace outputs.
Validation on this branch: