Skip to content

CH-003: CI builds the native client on Linux only - #19

Merged
flemming-n-larsen merged 5 commits into
mainfrom
ch-003-ci-native-build-linux-only
Sep 13, 2026
Merged

flemming-n-larsen merged 5 commits into
mainfrom
ch-003-ci-native-build-linux-only

Conversation

@flemming-n-larsen

@flemming-n-larsen flemming-n-larsen commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Acceptance brief

  • Plan item and whether it remains wanted: plan-less; follows CH-002 as scoped by the maintainer and serves G-001, which remains wanted.
  • The vision this change proceeds under: VIS-001 — Enable community-run ranked Tank Royale battles (status: draft, inferred).
  • Added or changed criteria: none.
  • What becomes binding on merge: ADR-002 (inferred, agent-authored) — CI builds and tests the native client on Linux only; native Windows and macOS runs stay supported but are no longer CI-tested. The build (windows-latest) and build (macos-latest) checks disappear and the job is reported as build. No unaccepted base.

A green build, complete form, or confident agent is not evidence that this outcome is wanted or that the criteria reflect reality. Keep this brief to one screen; split a change rather than hiding material meaning.

Summary

.github/workflows/build.yml's build job runs only on ubuntu-latest; the OS matrix, the Windows-only gradlew.bat step, and the Linux-only condition on the artifact upload are removed. The docker job is unchanged. The README states that native Windows and macOS runs are not CI-tested, and the architecture overview links ADR-002. No changelog entry: CI platform scope is not user-facing. Editorial: the CH-002 launcher-default entry moves from [Unreleased] to [0.1.0], because the changelog tracks the released image and the launchers are not part of it.

Documentation impact: README.md, docs/architecture/README.md, and docs/decisions/ (ADR-002 and index) changed; docs/design/README.md needed no change.

Verification

  • clue validate --forbid-changes: OK
  • git diff --check origin/main HEAD: clean
  • build.yml parses; build has runs-on: ubuntu-latest, no strategy, no OS conditions

Cliewen proposal

  • Change ID: CH-003
  • Plan item served: plan-less (follows CH-002, serves G-001)
  • Proposal location: /changes/CH-003-ci-native-build-linux-only/proposal.md (in commit a8f9bf8; deleted in digest)
  • Agentic review mode, reviewed commit, and pass count: context-isolated; 6502341; 1 completed pass (an earlier pass on f5d9dcf was stopped before returning)
  • Outstanding advisory findings:
    • README.md:68 says the container image is "the tested path on every host OS", but the docker job verifies it only on Linux with Docker; Windows/macOS container use is manually verified, not CI-tested (as README line 92 says). Reword to "the CI-tested path (verified on Linux)".
    • ADR-002's rationale says "the Linux build covers the supported default path on every host OS", but the image is verified by the docker job, on Linux only. Same overstatement; the decision is unaffected.
    • Branch protection: main has no required status checks or rulesets, so the job rename from build (ubuntu-latest) to build breaks nothing.
  • Hosted head reviewed before this update: 6502341 (draft)
  • Outstanding actionable findings: none

Traceability and Decisions

  • Acceptance criteria or capability meaning changed: none
  • Decision records added or changed: ADR-002
  • Constraints assessed: C-001 (no hard-wrapped Markdown) — satisfied

🤖 Generated with Claude Code

https://claude.ai/code/session_01KwJVGH7ftyX2ThQ2wMCLQK

flemming-n-larsen and others added 5 commits September 13, 2026 23:46
Opens CH-003, proposing that build.yml's build job run only on
ubuntu-latest now that the published container image is the default way
to run the client, with ADR-002 recording the choice.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KwJVGH7ftyX2ThQ2wMCLQK
build.yml's build job runs only on ubuntu-latest; the OS matrix and the
Windows-only gradlew step are removed. Adds ADR-002, links it from the
architecture overview, notes in the README that native Windows and macOS
runs are not CI-tested, and adds an Unreleased changelog entry.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KwJVGH7ftyX2ThQ2wMCLQK
Deletes the CH-003 change workspace now that every task is done;
ADR-002, the architecture overview, and the README carry the durable
record.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KwJVGH7ftyX2ThQ2wMCLQK
CI platform scope is not a user-facing change, so it does not belong in
the changelog; the README note on native Windows and macOS covers users.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KwJVGH7ftyX2ThQ2wMCLQK
The launchers are not part of the image, so the change to their default
image concerns using the published 0.1.0 image rather than a new
release. Move the entry from Unreleased to 0.1.0 and restore the blank
line lost before the 0.1.0 heading.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KwJVGH7ftyX2ThQ2wMCLQK
@flemming-n-larsen
flemming-n-larsen marked this pull request as ready for review September 13, 2026 21:54
@flemming-n-larsen
flemming-n-larsen merged commit 6059a4b into main Sep 13, 2026
5 checks passed
@flemming-n-larsen
flemming-n-larsen deleted the ch-003-ci-native-build-linux-only branch September 13, 2026 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant