CH-003: CI builds the native client on Linux only - #19
Merged
Merged
Conversation
Opens CH-003, proposing that build.yml's build job run only on ubuntu-latest now that the published container image is the default way to run the client, with ADR-002 recording the choice. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KwJVGH7ftyX2ThQ2wMCLQK
build.yml's build job runs only on ubuntu-latest; the OS matrix and the Windows-only gradlew step are removed. Adds ADR-002, links it from the architecture overview, notes in the README that native Windows and macOS runs are not CI-tested, and adds an Unreleased changelog entry. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KwJVGH7ftyX2ThQ2wMCLQK
Deletes the CH-003 change workspace now that every task is done; ADR-002, the architecture overview, and the README carry the durable record. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KwJVGH7ftyX2ThQ2wMCLQK
CI platform scope is not a user-facing change, so it does not belong in the changelog; the README note on native Windows and macOS covers users. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KwJVGH7ftyX2ThQ2wMCLQK
The launchers are not part of the image, so the change to their default image concerns using the published 0.1.0 image rather than a new release. Move the entry from Unreleased to 0.1.0 and restore the blank line lost before the 0.1.0 heading. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KwJVGH7ftyX2ThQ2wMCLQK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Acceptance brief
status: draft, inferred).build (windows-latest)andbuild (macos-latest)checks disappear and the job is reported asbuild. No unaccepted base.Summary
.github/workflows/build.yml'sbuildjob runs only onubuntu-latest; the OS matrix, the Windows-onlygradlew.batstep, and the Linux-only condition on the artifact upload are removed. Thedockerjob is unchanged. The README states that native Windows and macOS runs are not CI-tested, and the architecture overview links ADR-002. No changelog entry: CI platform scope is not user-facing. Editorial: the CH-002 launcher-default entry moves from[Unreleased]to[0.1.0], because the changelog tracks the released image and the launchers are not part of it.Documentation impact:
README.md,docs/architecture/README.md, anddocs/decisions/(ADR-002 and index) changed;docs/design/README.mdneeded no change.Verification
clue validate --forbid-changes: OKgit diff --check origin/main HEAD: cleanbuild.ymlparses;buildhasruns-on: ubuntu-latest, nostrategy, no OS conditionsCliewen proposal
CH-003/changes/CH-003-ci-native-build-linux-only/proposal.md(in commit a8f9bf8; deleted in digest)README.md:68says the container image is "the tested path on every host OS", but thedockerjob verifies it only on Linux with Docker; Windows/macOS container use is manually verified, not CI-tested (as README line 92 says). Reword to "the CI-tested path (verified on Linux)".dockerjob, on Linux only. Same overstatement; the decision is unaffected.mainhas no required status checks or rulesets, so the job rename frombuild (ubuntu-latest)tobuildbreaks nothing.Traceability and Decisions
🤖 Generated with Claude Code
https://claude.ai/code/session_01KwJVGH7ftyX2ThQ2wMCLQK