Repository navigation
feat: loading animation - #415
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a user experience improvement to the tour component by visually indicating when the next step is being prepared and may take a moment to appear. Now, if a step transition is delayed (due to loading data, rendering, or other async operations), the tooltip dims and shows a progress cursor to signal that the tour is working, both on web and React Native. This prevents confusion where previously the UI appeared unresponsive. The change is documented, implemented across platforms, and tested.
User experience improvements:
Implementation details:
isWaitingprop and related logic toTooltipFrameand its call sites, controlling the dimming effect and progress cursor. [1] [2] [3] [4] [5] [6] [7]waitingOpacityfor the dimmed state and clarifiedwaitingDimDelayMsfor when the effect should start.Documentation and testing:
CHANGELOG.mdandREADME.mdto describe the new behavior. [1] [2]