Open
Conversation
robch-bot
approved these changes
Jun 9, 2025
46263c9 to
f265ff2
Compare
99d08f2 to
d61632e
Compare
This brings an important and useful change - it will now auto-detect if you are on an Arm64 platform and default to using that as the platform for the image. This is important on Arm64 machines where the CPU emulation is not 100% stable. We have seen failures on Windows/WSL Linux on Arm64 Windows systems where the linux/amd64 code would sometimes fail due to some memory corruption. The best guess is some issue with multi-threaded memory access and the difference in memory model between the Arm and Intel CPUs and the qemu emulation not fully taking that into account. Anyway, this should help those users to not have to manually override the platform setting to use the native form. The default should now match Arm64 platforms. (Just the default but that makes it easier to use - all overrides and settings will continue to work as before.)
Cycod changes to dotnet 9.0 so we had to update the sdk version to match.
cf1f46a to
a269f80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings an important and useful change - it will now auto-detect if you are on an Arm64 platform and default to using that as the platform for the image.
This is important on Arm64 machines where the CPU emulation is not 100% stable. We have seen failures on Windows/WSL Linux on Arm64 Windows systems where the linux/amd64 code would sometimes fail due to some memory corruption. The best guess is some issue with multi-threaded memory access and the difference in memory model between the Arm and Intel CPUs and the qemu emulation not fully taking that into account.
Anyway, this should help those users to not have to manually override the platform setting to use the native form. The default should now match Arm64 platforms. (Just the default but that makes it easier to use - all overrides and settings will continue to work as before.)