Skip to content

fix: remove reasoningSummary parameter from GPT model requests #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rndubs wants to merge 1 commit into
base: claude/strip-telemetry-981PI
Choose a base branch
from
Open

fix: remove reasoningSummary parameter from GPT model requests #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions packages/opencode/src/provider/transform.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,6 @@ export namespace ProviderTransform {
effort,
{
reasoningEffort: effort,
reasoningSummary: "auto",
include: ["reasoning.encrypted_content"],
},
]),
Expand Down Expand Up @@ -478,7 +477,6 @@ export namespace ProviderTransform {
effort,
{
reasoningEffort: effort,
reasoningSummary: "auto",
include: ["reasoning.encrypted_content"],
},
]),
Expand Down Expand Up @@ -508,7 +506,6 @@ export namespace ProviderTransform {
effort,
{
reasoningEffort: effort,
reasoningSummary: "auto",
include: ["reasoning.encrypted_content"],
},
]),
Expand Down Expand Up @@ -759,7 +756,6 @@ export namespace ProviderTransform {
if (input.model.api.id.includes("gpt-5") && !input.model.api.id.includes("gpt-5-chat")) {
if (!input.model.api.id.includes("gpt-5-pro")) {
result["reasoningEffort"] = "medium"
result["reasoningSummary"] = "auto"
}

// Only set textVerbosity for non-chat gpt-5.x models
Expand All @@ -776,7 +772,6 @@ export namespace ProviderTransform {
if (input.model.providerID.startsWith("opencode")) {
result["promptCacheKey"] = input.sessionID
result["include"] = ["reasoning.encrypted_content"]
result["reasoningSummary"] = "auto"
}
}

Expand Down
8 changes: 2 additions & 6 deletions packages/opencode/test/provider/transform.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1823,7 +1823,6 @@ describe("ProviderTransform.variants", () => {
expect(Object.keys(result)).toEqual(["low", "medium", "high"])
expect(result.low).toEqual({
reasoningEffort: "low",
reasoningSummary: "auto",
include: ["reasoning.encrypted_content"],
})
})
Expand Down Expand Up @@ -1884,7 +1883,6 @@ describe("ProviderTransform.variants", () => {
expect(Object.keys(result)).toEqual(["low", "medium", "high", "xhigh"])
expect(result.xhigh).toEqual({
reasoningEffort: "xhigh",
reasoningSummary: "auto",
include: ["reasoning.encrypted_content"],
})
})
Expand Down Expand Up @@ -2023,7 +2021,7 @@ describe("ProviderTransform.variants", () => {
expect(result).toEqual({})
})

test("standard azure models return custom efforts with reasoningSummary", () => {
test("standard azure models return custom efforts", () => {
const model = createMockModel({
id: "o1",
providerID: "azure",
Expand All @@ -2037,7 +2035,6 @@ describe("ProviderTransform.variants", () => {
expect(Object.keys(result)).toEqual(["low", "medium", "high"])
expect(result.low).toEqual({
reasoningEffort: "low",
reasoningSummary: "auto",
include: ["reasoning.encrypted_content"],
})
})
Expand Down Expand Up @@ -2072,7 +2069,7 @@ describe("ProviderTransform.variants", () => {
expect(result).toEqual({})
})

test("standard openai models return custom efforts with reasoningSummary", () => {
test("standard openai models return custom efforts", () => {
const model = createMockModel({
id: "gpt-5",
providerID: "openai",
Expand All @@ -2087,7 +2084,6 @@ describe("ProviderTransform.variants", () => {
expect(Object.keys(result)).toEqual(["minimal", "low", "medium", "high"])
expect(result.low).toEqual({
reasoningEffort: "low",
reasoningSummary: "auto",
include: ["reasoning.encrypted_content"],
})
})
Expand Down