Fixed doCommand not parsing ','#1
Open
Fraser513 wants to merge 2 commits intormit-computing-technologies:mainfrom
Open
Fixed doCommand not parsing ','#1Fraser513 wants to merge 2 commits intormit-computing-technologies:mainfrom
Fraser513 wants to merge 2 commits intormit-computing-technologies:mainfrom
Conversation
…function to properly parse ',' and execute full commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Update ELCI to Properly Handle
doCommandReplaced the ELCI with a more recent version which patches the
doCommandfunction to properly parse commas (,) and execute full commands.Reason for Fix
This is required for the house building task:
Example
mc.doCommand("setblock 0 -60 -2 minecraft:dark_oak_stairs[facing= north, half= top]")
Before the , would be cut and the command would fail.
This ensures that commands sent from the C++ side are executed correctly in Minecraft without losing arguments due to comma parsing issues.