Conversation
…p (including parallel), and real2ff transformation."
rmchurch
reviewed
Sep 28, 2022
rmchurch
left a comment
rmchurch
left a comment
Owner
There was a problem hiding this comment.
Overall looks good, made minor request for changing GradPlane, etc. to have lower-case, and in particular GradPlane whether gradRZ makes more sense.
| return bdotgrad_field | ||
|
|
||
| # Calculates the (psi,theta)/(R,Z) derivative of field. | ||
| def GradPlane(self,field): |
Owner
There was a problem hiding this comment.
Perhaps gradRZ a more descriptive name? Also, in general, style-wise I've been lower-casing first letter of method names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds routines:
b.grad(...)(usingxgc.grad_rz.bpand field-line mapping datareal2fftransformation, i.e., transformation to field-following representation (e.g.As_phi_ff)ff2realtransformation (this is not executed now because it takes a while to generate the matrices forff2realfrom the mapping data.As_phi_ffanddAs_phi_ff(forrho_i=0) and writes that into an Adios BP fileThe purpose of this update is the capability to generate the input data required by Dave Pugmires field-line tracer tool from any XGC simulation.