Skip to content

Fix unable to build and update UI to Fluent style#15

Open
blueblur22 wants to merge 7 commits into
rmboggs:mainfrom
blueblur22:main
Open

Fix unable to build and update UI to Fluent style#15
blueblur22 wants to merge 7 commits into
rmboggs:mainfrom
blueblur22:main

Conversation

@blueblur22
Copy link
Copy Markdown

@blueblur22 blueblur22 commented Apr 24, 2025

Fixes #14

  • update dependencies
  • target NET9
  • additional corrections necessary for changes in the latest dependencies

Additionally, this updates the UI to the modern fluent style added in NET9.

Dark:
image
Light:
image

Copy link
Copy Markdown
Owner

@rmboggs rmboggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see about the targetframework suggestion before approval.

Comment thread src/DocxToSource/DocxToSource.csproj Outdated
</PropertyGroup>
<PropertyGroup>
<OutputType>WinExe</OutputType>
<TargetFramework>net9.0-windows7.0</TargetFramework>
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to have this target both net8 and net9? I ask because I think support for net9 will be EOL before net8.

Also, not to nitpick but can we get rid of the space changes?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the spacing, I have an extension that does that automatically. I've reverted the MainWindow to your previous styling and formatted the incoming changes to better match as well in b546eb9.

As for the NET8 downgrade, I tested it and am unable to do this without reverting everything back to the old Win7 stock theme. As a compromise, when NET10 releases in a few months, I can update the project again with another PR. Would that be acceptable?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted the project file spacing too (7f46785). Let me know if I missed anything.

@blueblur22 blueblur22 requested a review from rmboggs June 25, 2025 16:07
@blueblur22
Copy link
Copy Markdown
Author

@rmboggs I've upgraded the project to NET10 since it's finally hit release. It will have support out to Nov 2028. Let me know if this doesn't address your concerns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable To Build Main Branch

2 participants