feat: make JVM dashboards incident-drilldown ready#268
Merged
Conversation
Dashboard operators need one contract across Grafana, Helm, Fleet, Profiles, and Console so incident triage does not drift between fleet and selected-pod views. Constraint: Grafana, Helm, and static local dashboards must stay dependency-light and work for unlabeled local Prometheus scrapes. Rejected: Treat Grafana variables as display-only | filters must affect panel PromQL and be regression-tested. Rejected: Keep per-page pod selection helpers | shared pod-context prevents drift across dashboard surfaces. Confidence: high Scope-risk: moderate Directive: Keep docs/grafana-dashboard.json and charts/argus/dashboards/argus-jvm-observability.json byte-equivalent; update docs/dashboard-contract.md before adding dashboard metrics. Tested: ./gradlew test; targeted dashboard tests; node --check changed dashboard JS; Grafana JSON selector/chart parity; git diff --check; local curl smoke. Not-tested: Browser visual automation was unavailable in Codex tool search; static HTTP smoke covered page load only. Signed-off-by: rlaope <piyrw9754@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pod-context.js, incident synopsis, Fleet top reasons, and preserved pod/profile/console links.Verification
./gradlew test./gradlew :argus-server:test --tests io.argus.server.metrics.GrafanaDashboardMetricReferencesTest --tests io.argus.server.metrics.DashboardStaticAssetsSmokeTestnode --checkon changed dashboard JS filesgit diff --check/,/fleet.html,/profiles.html?pod=...,/console.html?pod=..., and/js/pod-context.jsQuality Gate
ArgusPodContext.