fix: bound diagnostic subprocess timeout behavior#267
Merged
Conversation
Async-profiler captures and jcmd-backed diagnostics sit on user-facing command paths, so their timeout contracts need to bound total wall time even when child processes keep running or produce no output. Constraint: Argus must keep Java 11 compatibility and avoid new runtime dependencies for process supervision. Rejected: Replacing the diagnostic command layer with async futures | too broad for a targeted performance-risk pass. Confidence: high Scope-risk: narrow Directive: Keep stdout/stderr draining independent from timeout enforcement for long-running diagnostic subprocesses. Tested: ./gradlew :argus-cli:test --tests io.argus.cli.provider.jdk.AsProfExecutorTest --quiet; ./gradlew :argus-server:test --tests io.argus.server.command.impl.DiagnosticUtilTest --tests io.argus.server.command.ServerCommandExecutorTest --quiet; ./gradlew :argus-cli:test :argus-diagnostics:test :argus-server:test :argus-agent:test :argus-aggregator:test :argus-spring-boot-starter:test :argus-instrument:test :argus-cli:fatJar --quiet Not-tested: Live async-profiler/JFR capture against a production JVM under load. Signed-off-by: rlaope <piyrw9754@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AsProfExecutorto a single timeout budget usingSystem.nanoTime()and remaining-time waits.compilerqueuethrough the shared jcmd timeout path while preserving its in-process pid and error-return behavior.Performance/Reliability Impact
readAllBytes()before timeout enforcement.Validation
./gradlew :argus-cli:test --tests io.argus.cli.provider.jdk.AsProfExecutorTest --quiet./gradlew :argus-server:test --tests io.argus.server.command.impl.DiagnosticUtilTest --tests io.argus.server.command.ServerCommandExecutorTest --quiet./gradlew :argus-cli:test :argus-diagnostics:test :argus-server:test :argus-agent:test :argus-aggregator:test :argus-spring-boot-starter:test :argus-instrument:test :argus-cli:fatJar --quietNotes
/Users/rlaope/Desktop/khope/Argus-performance-clean; the original worktree has pre-existing untracked duplicate Java files that block Gradle baseline evaluation there.