Add platform check to RedistInstall.cs#671
Merged
rlabrecque merged 1 commit intorlabrecque:masterfrom Mar 21, 2025
khyperia:add-platform-check-redist-install
Merged
Add platform check to RedistInstall.cs#671rlabrecque merged 1 commit intorlabrecque:masterfrom khyperia:add-platform-check-redist-install
rlabrecque merged 1 commit intorlabrecque:masterfrom
khyperia:add-platform-check-redist-install
Conversation
Contributor
Author
|
Just realized #660 does the same thing. It would be great if either one of these could be merged! |
Contributor
Author
|
Hi! Ping on this @rlabrecque , if you have time, could you review/merge either this PR or #660? It'd be lovely to no longer have to use a fork for our projects! Thanks |
This was referenced Jun 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This check:
https://github.com/khyperia/Steamworks.NET/blob/2ceddb2c35c88f069bbd8927b949a3d4eadb4e58/com.rlabrecque.steamworks.net/Editor/RedistCopy.cs#L20-L23
should be done in RedistInstall.cs as well: right now, the STEAMWORKS_NET define is getting added to every platform automatically. This is no good, it breaks stuff! It should not be added for non-Standalone (mac, win, linux) platforms.
(used selectedBuildTargetGroup because it's used again later in RedistInstall.cs, to add the STEAMWORKS_NET define)
(Thanks for your time, and thanks for making such a great library!)