When calling grepWin, pass target directory on command line instead o…#5857
Open
lhmouse wants to merge 1 commit into
Open
When calling grepWin, pass target directory on command line instead o…#5857lhmouse wants to merge 1 commit into
lhmouse wants to merge 1 commit into
Conversation
…f via INI In single-instance mode, if there's another instance of grepWin, the new process does not read `searchpath` from the INI; it always forwards whatever from the command line to the running instance. Since Notepad3 did not pass `/searchpath:`, the running grepWin received the working directory of the new process. The path is now passed via the `/searchpath:` option, and is not written to `grepwin.ini` any more.
Contributor
Author
|
There's another bug in grepWin3: stefankueng/grepWin#596 |
There was a problem hiding this comment.
Pull request overview
This PR updates Notepad3’s grepWin integration so the target search directory is passed directly on grepWin’s command line (/searchpath:) rather than being written into grepwin.ini, addressing single-instance grepWin behavior where INI-provided searchpath is ignored for subsequent invocations.
Changes:
- Stop writing
searchpathintogrepwin.iniduringDialogGrepWin(). - Compute the intended search directory (current file’s folder or working directory) and pass it via
/searchpath:"..."in the grepWin invocation.
Contributor
Author
|
The CI log says 'ERROR: Notepad3's About Box can not be closed!' |
Collaborator
|
Hi @RaiKoHoff , |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…f via INI
In single-instance mode, if there's another instance of grepWin, the new process does not read
searchpathfrom the INI; it always forwards whatever from the command line to the running instance.Since Notepad3 did not pass
/searchpath:, the running grepWin received the working directory of the new process.The path is now passed via the
/searchpath:option, and is not written togrepwin.iniany more.