Skip to content

[PR] Moving file operations out of lib.rs and into its own crate.#238

Merged
rjsmith1999 merged 10 commits into
mainfrom
libresolve-move-file-ops
Jul 15, 2026
Merged

[PR] Moving file operations out of lib.rs and into its own crate.#238
rjsmith1999 merged 10 commits into
mainfrom
libresolve-move-file-ops

Conversation

@elazaro-riverside

@elazaro-riverside elazaro-riverside commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Refactored the libresolve runtime project to move file operations out of lib.rs and into its own crate. I believe this helps declutter the lib.rs file.

@elazaro-riverside elazaro-riverside self-assigned this Jul 10, 2026
@elazaro-riverside elazaro-riverside added repo maintainance Changes repository structure or organization focused changes libresolve Related to libresolve component labels Jul 10, 2026
@elazaro-riverside
elazaro-riverside marked this pull request as ready for review July 13, 2026 12:23

@zoogies zoogies left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjsmith1999 rjsmith1999 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do something different with MutexWrap? It seems out of place in this file.

What if we just made an alias in lib.rs Mutex = parking_lot::Mutex, and everyone can import crate::Mutex.
That way we can still swap it later?

@rjsmith1999

Copy link
Copy Markdown
Collaborator

Can we do something different with MutexWrap? It seems out of place in this file.

What if we just made an alias in lib.rs Mutex = parking_lot::Mutex, and everyone can import crate::Mutex. That way we can still swap it later?

Or just leave mutex wrap in lib.rs

@elazaro-riverside

Copy link
Copy Markdown
Collaborator Author

Note to self: Make alias in lib.rs and import crate::Mutex.

Comment thread resolve-cveassert/libresolve/src/lib.rs Outdated

@rjsmith1999 rjsmith1999 Jul 15, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elazaro-riverside This comment is no longer applicable and should be removed, do you understand why it doesn't apply now?

Comment thread resolve-cveassert/libresolve/src/lib.rs Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Comment thread resolve-cveassert/libresolve/src/lib.rs Outdated
Comment on lines +12 to +13
use parking_lot::{MutexGuard};
pub type Mutex<T> = parking_lot::Mutex<T>;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
use parking_lot::{MutexGuard};
pub type Mutex<T> = parking_lot::Mutex<T>;
use parking_lot::{Mutex, MutexGuard};

@rjsmith1999
rjsmith1999 enabled auto-merge July 15, 2026 16:23
@rjsmith1999
rjsmith1999 merged commit 9bf0a0d into main Jul 15, 2026
1 check passed
@rjsmith1999
rjsmith1999 deleted the libresolve-move-file-ops branch July 15, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

libresolve Related to libresolve component repo maintainance Changes repository structure or organization focused changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants