[PR] Moving file operations out of lib.rs and into its own crate.#238
Conversation
rjsmith1999
left a comment
There was a problem hiding this comment.
Can we do something different with MutexWrap? It seems out of place in this file.
What if we just made an alias in lib.rs Mutex = parking_lot::Mutex, and everyone can import crate::Mutex.
That way we can still swap it later?
Or just leave mutex wrap in lib.rs |
|
Note to self: Make alias in |
There was a problem hiding this comment.
@elazaro-riverside This comment is no longer applicable and should be removed, do you understand why it doesn't apply now?
| use parking_lot::{MutexGuard}; | ||
| pub type Mutex<T> = parking_lot::Mutex<T>; |
There was a problem hiding this comment.
| use parking_lot::{MutexGuard}; | |
| pub type Mutex<T> = parking_lot::Mutex<T>; | |
| use parking_lot::{Mutex, MutexGuard}; |
Refactored the libresolve runtime project to move file operations out of
lib.rsand into its own crate. I believe this helps declutter thelib.rsfile.