Upgrade to golangci-lint v2.2.1 + disable some annoying lints + fix others#989
Merged
Merged
Conversation
…thers Here, upgrade golangci-lint to v2.2.1, mostly because my local version is upgraded and throwing problems. Some really, really, really-no-good lints have been added (`noinlineerr` and `wsl_v5`) which we disable. Some others have been added which are good, which we keep. One checks that there's a consistent whitespace between embedded structs and other properties on a struct definition. Another makes sure we're using the context form of logging functions, so `WarnContext` instead of `Warn`.
brandur
force-pushed
the
brandur-golang-ci-lint-v2.2.1-upgrade
branch
from
0bc6301 to
baf299f
Compare
bgentry
approved these changes
Jul 27, 2025
bgentry
left a comment
bgentry
left a comment
Contributor
There was a problem hiding this comment.
I had that inline error one pop up the other day, who decided to pull that in as a default?? 🤦🏼♂️
Contributor
Author
Yeah it's crazy! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here, upgrade golangci-lint to v2.2.1, mostly because my local version
is upgraded and throwing problems.
Some really, really, really-no-good lints have been added (
noinlineerrand
wsl_v5) which we disable.Some others have been added which are good, which we keep. One checks
that there's a consistent whitespace between embedded structs and other
properties on a struct definition. Another makes sure we're using the
context form of logging functions, so
WarnContextinstead ofWarn.