Move SQLite journal mode pragma to connection string#956
Merged
Conversation
bgentry
approved these changes
Jun 19, 2025
A small change to move the pragma to activate `journal_mode` to the connection string instead of being run separately as its own `PRAGMA` command. It should be a tiny bit faster, and it's not harmful for legibility (in fact, I think it improves it in a small way too).
brandur
force-pushed
the
brandur-pragma-connection-string
branch
from
cf638a0 to
9bd6689
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A small change to move the pragma to activate
journal_modeto theconnection string instead of being run separately as its own
PRAGMAcommand. It should be a tiny bit faster, and it's not harmful for
legibility (in fact, I think it improves it in a small way too).