Extract mapSliceError into rivershared sliceutil.MapError function#942
Merged
Conversation
I just noticed that we end up redefining `mapSliceError` in every driver. Here, extract it into `rivershared` as `sliceutil.MapError` so it can be reused everywhere. It's a good time to do this anyway because we're about to have a mandatory update across project boundaries so Pro will be able to get access to it too.
bgentry
approved these changes
Jun 4, 2025
Contributor
Author
|
Thx. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I just noticed that we end up redefining
mapSliceErrorin everydriver. Here, extract it into
riversharedassliceutil.MapErrorsoit can be reused everywhere. It's a good time to do this anyway because
we're about to have a mandatory update across project boundaries so Pro
will be able to get access to it too.