tweak config metadata updates, fix adding existing queue#929
Merged
Conversation
bgentry
force-pushed
the
bg-queue-config-store
branch
from
80e8802 to
dfc9766
Compare
brandur
approved these changes
May 25, 2025
bgentry
force-pushed
the
bg-queue-config-store
branch
2 times, most recently
from
17997b9 to
a2e3e1e
Compare
Some small changes to the pilot integration APIs to facilitate equivalent Pro changes. While in here, I realized it's possible to add a queue that already exists, an undefined behavior which could result in a leaked producer. To fix that, I introduced an exported error type and made use of it on this API.
bgentry
force-pushed
the
bg-queue-config-store
branch
from
b20a29e to
207faa4
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some small changes to the pilot integration APIs to facilitate equivalent Pro changes. While in here, I realized it's possible to add a queue that already exists, an undefined behavior which could result in a leaked producer. To fix that, I introduced an exported error type and made use of it on this API.