Return error about job list metadata on SQLite on JobListTx#924
Merged
Conversation
brandur
force-pushed
the
brandur-better-job-list-tx-error
branch
from
b89e9de to
4c710bf
Compare
bgentry
approved these changes
May 23, 2025
|
|
||
| if c.driver.DatabaseName() == "sqlite" && params.metadataFragment != "" { | ||
| return nil, errors.New("JobListResult.Metadata is not supported on SQLite") | ||
| if c.driver.DatabaseName() == databaseNameSQLite && params.metadataFragment != "" { |
Contributor
There was a problem hiding this comment.
Maybe a note should go in the method's documentation too?
Contributor
Author
There was a problem hiding this comment.
WFM. I added one on the JobListParams.Metadata function. This worked out well since that wasn't previously documented, so now we've got docs plus the SQLite caveat.
Fix a problem reported in #923. We return a special error on SQLite when someone tries to use `JobListParams.Metadata` because we can't support the Postgres `@>` operator, which doesn't exist in any other database. Somehow, this error was only returned on `JobList` and not `JobListTx`. Here, bring it to `JobListTx` too. Add a new set of client driver tests for `JobListTx` so we're doing reasonable exercise the function under SQLite.
brandur
force-pushed
the
brandur-better-job-list-tx-error
branch
from
4c710bf to
9868308
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a problem reported in #923. We return a special error on SQLite when
someone tries to use
JobListParams.Metadatabecause we can't supportthe Postgres
@>operator, which doesn't exist in any other database.Somehow, this error was only returned on
JobListand notJobListTx.Here, bring it to
JobListTxtoo. Add a new set of client driver testsfor
JobListTxso we're doing reasonable exercise the function underSQLite.