Skip to content

Expand SQLite comment to talk about busy_timeout #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandur merged 1 commit into from
May 24, 2025
Merged

Expand SQLite comment to talk about busy_timeout #913

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions rivershared/riversharedtest/riversharedtest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,10 @@ func DBPoolSQLite(ctx context.Context, tb testing.TB, schema string) *sql.DB {
// anyway. See for example:
//
// https://news.ycombinator.com/item?id=30369095
//
// An alternative approach is to increase `PRAGMA busy_timeout`, but I've
// found that we still run into `SQLITE_BUSY` errors with that at higher
// iteration counts like `-run TestClientWithDriverRiverSQLite -count 100`.
dbPool.SetMaxOpenConns(1)

// This innocuous line turns out to be quite important at the tail.
Expand Down
Loading