Remove TimeStub from rivertest#912
Merged
Merged
Conversation
I was looking through the public API surface area of `rivertest` [1] and noticed that we actually have a `TimeStub` in there. I think this was accidental export from a time before we had a `TimeStub` available in `rivershared`. I think we should take this out. Technically it's a breaking change given it was part of the public API, but there wasn't a whole bunch that anyone would need this for, so I doubt usage is significant, and hopefully no one's using it at all. [1] https://pkg.go.dev/github.com/riverqueue/river/rivertest
brandur
force-pushed
the
brandur-remove-time-stub
branch
from
8550cab to
3b6f383
Compare
bgentry
approved these changes
May 23, 2025
bgentry
left a comment
bgentry
left a comment
Contributor
There was a problem hiding this comment.
Good find and agree, nobody should be using this anyway so hopefully it won't impact anybody.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was looking through the public API surface area of
rivertest[1] andnoticed that we actually have a
TimeStubin there. I think this wasaccidental export from a time before we had a
TimeStubavailable inrivershared.I think we should take this out. Technically it's a breaking change
given it was part of the public API, but there wasn't a whole bunch that
anyone would need this for, so I doubt usage is significant, and
hopefully no one's using it at all.
[1] https://pkg.go.dev/github.com/riverqueue/river/rivertest