Push REINDEX down into driver so reindexer works on SQLite#911
Merged
Conversation
bgentry
approved these changes
May 23, 2025
I realized when #909 that the reindexer isn't currently compatible with the SQLite driver because SQLite's `REINDEX` syntax is a little different, and it doesn't support the `CONCURRENTLY` keyword. The reindexer runs once an hour so nothing caught the problem. Here, push the reindex command down into the driver and add a test for it. This is a good time to do this since we're changing the driver interface by the necessity for the next version anyway so we're not breaking anything that's not already broken. One outstanding issue is that SQLite can't reindex concurrently so the reindexer would fully lock the database while it's reindexing the configured indexes. There's nothing that can be done about this for now, so we might have to recommend that users running a larger database disable the reindexer if they're using SQLite.
brandur
force-pushed
the
brandur-reindex-driver
branch
from
fb7390f to
e44ebc6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realized when #909 that the reindexer isn't currently compatible with
the SQLite driver because SQLite's
REINDEXsyntax is a littledifferent, and it doesn't support the
CONCURRENTLYkeyword. Thereindexer runs once an hour so nothing caught the problem.
Here, push the reindex command down into the driver and add a test for
it. This is a good time to do this since we're changing the driver
interface by the necessity for the next version anyway so we're not
breaking anything that's not already broken.
One outstanding issue is that SQLite can't reindex concurrently so the
reindexer would fully lock the database while it's reindexing the
configured indexes. There's nothing that can be done about this for now,
so we might have to recommend that users running a larger database
disable the reindexer if they're using SQLite.