Remove TODO on duplicated work unit wrapper + add explanatory comment#1011
Merged
Conversation
This one comes from me trying to find a good alternative to fix a TODO in `rivertest/worker.go` over the duplicated work unit wrapper and factory types. Unfortunately I found that there is no good fix available because anything we do introduces a cyclic dependency. Having put very low level types like `Job`, `JobArgs, and `Worker` into the top-level `river` package unfortunately acts to hugely limit our ability to move things around. So instead, I just remove the TODO here since there's nothing to be done, and replace it with an explanatory comment saying how this isn't great, but it's the only viable method that we know of.
bgentry
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one comes from me trying to find a good alternative to fix a TODO
in
rivertest/worker.goover the duplicated work unit wrapper andfactory types. Unfortunately I found that there is no good fix available
because anything we do introduces a cyclic dependency. Having put very
low level types like
Job,JobArgs, andWorkerinto the top-levelriver` package unfortunately acts to hugely limit our ability to movethings around.
So instead, I just remove the TODO here since there's nothing to be
done, and replace it with an explanatory comment saying how this isn't
great, but it's the only viable method that we know of.