Eliminate TODO stored to error trace from job rescuer#1010
Merged
Conversation
Here, eliminate a TODO that's stored to an error's `trace` when a job is rescued by `JobRescuer`. I've changed this to an empty string instead and documented that it'll be an empty string.
brandur
force-pushed
the
brandur-eliminate-trace-todo
branch
from
0dca55e to
200257f
Compare
Contributor
Author
|
Kinda found this one by accident looking through TODOs in the code. |
bgentry
approved these changes
Aug 14, 2025
bgentry
left a comment
bgentry
left a comment
Contributor
There was a problem hiding this comment.
Whoops, good find! Thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here, eliminate a TODO that's stored to an error's
tracewhen a job isrescued by
JobRescuer. I've changed this to an empty string insteadand documented that it'll be an empty string.