Skip to content

Expose internal insert function to pilot + optional ID during job insert#1001

Merged
brandur merged 1 commit into
masterfrom
brandur-redrive
Aug 14, 2025
Merged

Expose internal insert function to pilot + optional ID during job insert#1001
brandur merged 1 commit into
masterfrom
brandur-redrive

Conversation

@brandur

@brandur brandur commented Aug 9, 2025

Copy link
Copy Markdown
Contributor

Here, expose encapsulated core insert logic to the pilot so extensions
can get access to it. We also add an optional ID to job insertion, a
property that's not used most of the time but useful for fine-tine
control over insertion that's required in some circumstances.

@brandur

brandur commented Aug 9, 2025

Copy link
Copy Markdown
Contributor Author

Dang it, somehow got two changes mixed up with each other. Lemme untangle this.

@brandur

brandur commented Aug 9, 2025

Copy link
Copy Markdown
Contributor Author

Actually, NM, the changes are correct. I ended up changing the signature of the insertion functions so they're a bit simpler (in more insertSharedResult) and use only exported types.

@brandur brandur requested a review from bgentry August 9, 2025 21:55
Here, expose encapsulated core insert logic to the pilot so extensions
can get access to it. We also add an optional ID to job insertion, a
property that's not used most of the time but useful for fine-tine
control over insertion that's required in some circumstances.
@brandur brandur merged commit d278b65 into master Aug 14, 2025
10 checks passed
@brandur brandur deleted the brandur-redrive branch August 14, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants