Expose internal insert function to pilot + optional ID during job insert#1001
Merged
Conversation
b9afea6 to
c3fd837
Compare
Contributor
Author
|
Dang it, somehow got two changes mixed up with each other. Lemme untangle this. |
c3fd837 to
49ccc82
Compare
Contributor
Author
|
Actually, NM, the changes are correct. I ended up changing the signature of the insertion functions so they're a bit simpler (in more |
Here, expose encapsulated core insert logic to the pilot so extensions can get access to it. We also add an optional ID to job insertion, a property that's not used most of the time but useful for fine-tine control over insertion that's required in some circumstances.
49ccc82 to
3b7b75d
Compare
bgentry
approved these changes
Aug 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here, expose encapsulated core insert logic to the pilot so extensions
can get access to it. We also add an optional ID to job insertion, a
property that's not used most of the time but useful for fine-tine
control over insertion that's required in some circumstances.