fix(android): pass autoBind to SDK when dataBind is set (#156)#157
Open
fix(android): pass autoBind to SDK when dataBind is set (#156)#157
Conversation
mfazekas
force-pushed
the
fix/156-autobind-approach
branch
3 times, most recently
from
d8963f0 to
0468d6a
Compare
mfazekas
force-pushed
the
fix/156-autobind-approach
branch
3 times, most recently
from
657f76b to
849095a
Compare
mfazekas
force-pushed
the
fix/156-autobind-approach
branch
from
849095a to
1fcf9b4
Compare
Verifies VMI is bound to state machine without calling play(). Also adds EventTarget polyfill for chai 6.x in Hermes.
With autoPlay={false}, the SDK doesn't create state machines until
play(). Pass autoBind=true so they're created eagerly, removing
the need for _pendingBindData deferral.
mfazekas
force-pushed
the
fix/156-autobind-approach
branch
from
1fcf9b4 to
d865bca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #140 correctly removed the play() that was called even if autoplay was false, but it caused binding to break, as state machines were not initialised in rive-android. This PR implements a better workaround by passing autoBind=true to rive-android, to make sure a stateMahcines is valid. The only downside is that it set's up view model instance that we might override during configuration a bit later.
Fixes: #156
Reproducer (not committed)
Place in
example/src/reproducers/Issue156.tsx— usesquick_start.riv, sets health=25 via onInit withautoPlay={false}. Three modes:playIfNeeded()(bug path),play()(workaround), and tap graphic (user interaction). Health bar at ~25% = binding applied (PASS), ~100% = NOT applied (FAIL).Closes #156