This repository was archived by the owner on Dec 6, 2022. It is now read-only.
Open
Conversation
Catch errors thrown from Dir.mkdir. The script died for me because directories already existed. This helped. I haven't investigated why I had several "Current Database" for the same database, so maybe the problem would better be solved in another way.
Owner
|
Failing there has merit - to prevent accidentally overwriting a previous backup. Do you feel that's a concern? Should it rather show a friendly error in that case? |
Author
|
The error message was informative enough for me. Maybe it would be a better solution to add a command line switch for allowing the script to overwrite existing files. |
Owner
|
yeah - so I am reluctant to merge this PR as it, because this will silently fail and overwrite data without warning. do you have time to add such a flag? |
Author
|
I'm not used to do programming in ruby, so I think that you would do it quicker and better. But if you don't have time, maybe I could try to do it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Catch errors thrown from Dir.mkdir.
The script died for me because directories already existed. This helped.
I haven't investigated why I had several "Current Database" for the same database, so maybe the problem would better be solved in another way.